PDA

View Full Version : [FIXED-1007] FormPanel labelSeparator as an empty string is ignored



Supergibbs
28 May 2010, 2:43 PM
The documentation (http://www.extjs.com/deploy/dev/docs/?class=Ext.form.FormPanel&member=labelSeparator) is: See Ext.Component (http://www.extjs.com/deploy/dev/docs/?class=Ext.Component).labelSeparator (http://www.extjs.com/deploy/dev/docs/?class=Ext.Component&member=labelSeparator)

Where it says: To display no separator for this field's label specify empty string ''.

This works at the Component level but not at FormPanel as expected.

The fix is in Ext.layout.FormLayout.setContainer

the line:


this.labelSeparator = ct.labelSeparator || this.labelSeparator;should be


this.labelSeparator = (Ext.isDefined(ct.labelSeparator) ? ct.labelSeparator : this.labelSeparator);

evant
28 May 2010, 7:44 PM
This has been fixed in svn rev 6662. Thanks for the report.

Animal
30 May 2010, 10:00 PM
Using



new String('');


has always worked. That's a truthy value.