PDA

View Full Version : [FIXED-1074] Menu tab navigation visits hidden items.



Animal
26 Jun 2010, 4:48 AM
Menu.tryActivate attempts to navigate up or down the menu on SHIFT+TAB or TAB.

It checks whether the next/prev item is disabled, but not whether it is visible.

The fix is



Ext.override(Ext.menu.Menu, {
tryActivate : function(start, step){
var items = this.items;
for(var i = start, len = items.length; i >= 0 && i < len; i+= step){
var item = items.get(i);
if(!item.disabled && item.isVisible() && (item.canActivate || item.isFormField)){
this.setActiveItem(item, false);
return item;
}
}
return false;
}
});

evant
29 Jun 2010, 9:35 PM
Thanks Nige, fixed in SVN.