PDA

View Full Version : [FIXED-163] Component#isVisible implementation is wrong



dayext
23 Jul 2010, 6:09 AM
Hi,

method return "hidden=true" if is visible...



isVisible : function() {
if (!this.rendered) {
return false;
}
var p = this,
hidden = false;
while (p) {
if (p.hidden) {
hidden = true;
break;
}
p = p.ownerCt;
}
return hidden;
}

Sencha touch v0.91.

Regards,
alexc

Jamie Avins
23 Jul 2010, 8:41 AM
Yea, someone was up a little late writing that one.

DaveC426913
28 Jul 2010, 5:27 AM
Some confusion here.

1] So, has this been written as an addendum? Should I include that code in my page?

2] One of the things I was playing with was .rendered. I was finding components were returning rendered=true even when they had been set to not visible.

TommyMaintz
28 Jul 2010, 11:14 AM
This has been fixed and will be part of the 0.9.3 release next week.