PDA

View Full Version : [CLOSED]Component.onShow and Component.onHide overwrite the animation.after function



dhawkins
18 Aug 2010, 11:31 AM
It would be nice if those methods wouldn't overwrite the .after function passed in the animation config.

For example, the following example will never call the after function.


myComponent.hide({type: 'pop', after: function() { ... }});

Inside Component.js the code for adding the after handler in onHide should be something like:

var after = function() {
this.getVisibilityEl().hide();
};
if (hideConfig.after)
hideConfig.after = after.createInterceptor(hideConfig.after, hideConfig.scope||this);
else
hideConfig.after = after;

This will call the after function before calling the existing animation.after function
The same should be done in the onShow function.

--David

evant
18 Aug 2010, 7:57 PM
This is actually already the case, you should see it in the next release.