PDA

View Full Version : [FNR] BorderLayout presentation inconsistency



bobpardoe
16 Sep 2010, 12:58 AM
This is viewable in your explorer demo too.

When collapsing a west or east panel the panel's header remains in 'glossy' mode.

When collapsing a north or south panel the header is 'flat'.

When the north and south panels are in this flat mode, the button alignment is also wrong and collapse button no longer sits in the middle.

It looks poor but does not affect functionality

BOb

sven
16 Sep 2010, 1:11 AM
When collapsing a west or east panel the panel's header remains in 'glossy' mode. When collapsing a north or south panel the header is 'flat'. There is no real header anymore if you collapse. I dont know if we should change this, as it has this design for a very long time. What do other think?

bobpardoe
20 Sep 2010, 11:49 PM
Given that no one else has replied, could you make a decision as to whether you will fix it or not. In my view, just because it has been wrong for ages, that in it's self is not a reason to ignore it.

I have looked at the code and I can see that you are swapping out the panel that has the content and replacing it it with the empty panel. Could you not (turn off scrollng and) just set the size of the panel to the height of the header ?

BOb

sven
21 Sep 2010, 1:10 AM
In my view, just because it has been wrong for ages, that in it's self is not a reason to ignore it.
It is, because it would change every single application in an inacceptabel way for a minor version update. Also it is not wrong. It was designed to look this "flat" way.

We cannot do this change directly in GXT. First version we can look at it is GXT3.

Take a look at the CollapsePanel class. In onRender we remove the background image for north and south. You will need to show it again.

I am fixing the alignmenet directly in GXT.

sven
22 Sep 2010, 4:17 AM
I am fixing the alignmenet directly in GXT.
This is fixed in SVN now as of revision 2240