PDA

View Full Version : [CLOSED] BeanModelReader has wrong generic type



andrew_l
20 Sep 2010, 8:41 PM
BeanModelReader has the following signature :

BeanModelReader implements DataReader<ListLoadResult<ModelData>>however it will only ever contain BeanModel instances (or an empty list).

It should have the signature : BeanModelReader implements DataReader<ListLoadResult<BeanModel>>

This means the following code is needed by the client :

ListLoadResult<BeanModel> dataListLoadResult = ((ListLoadResult<BeanModel>)(ListLoadResult)reader.read(null, result));

which is pretty messy.

sven
21 Sep 2010, 1:03 AM
The generics on the dataloading api are overall wrong. Also we cannot change this in any minor version update.