PDA

View Full Version : [FNR] GXT 2.2 rev 2410 Grid views fail to scroll correctly when grid has > 33 rows



The_Jackal
10 Jul 2011, 10:25 PM
Hi Sven,

I'm using GXT 2.2 rev 2410 (for the ComboBox lazy render fix) but it has broken all grids (Grid and EditorGrid) that have more than 33 rows. When you grab the vertical scroll handle and scoll downwards, as you approach the end of the rows the vertical scroll bar drag handle starts shrinking and you can scroll way past the bottom of the data (then are not even any rows, just blankness).

This happened between rev 2388 (good) and 2410 (has issue).

I just tested it - it's rev 2402 by Rasmus that causes the problem.

Replacing:



@SuppressWarnings("unchecked")
protected void syncScroll() {
syncHeaderScroll();
int scrollLeft = scroller.getScrollLeft();
int scrollTop = scroller.getScrollTop();
GridEvent<ModelData> ge = (GridEvent<ModelData>) createComponentEvent(null);
ge.setScrollLeft(scrollLeft);
ge.setScrollTop(scrollTop);
focusEl.setXY(scrollLeft, scrollTop);
grid.fireEvent(Events.BodyScroll, ge);
}
with 2401's version



@SuppressWarnings("unchecked")
protected void syncScroll() {
syncHeaderScroll();
GridEvent<ModelData> ge = (GridEvent<ModelData>) createComponentEvent(null);
ge.setScrollLeft(scroller.getScrollLeft());
ge.setScrollTop(scroller.getScrollTop());
grid.fireEvent(Events.BodyScroll, ge);
}
fixes the problem.

Can you update me when this gets fixed?

Update:

Sven has provided a patch that fixes this issue (not in svn yet as of rev 2414)

Regards,
Carl

sven
13 Sep 2011, 5:41 AM
Fixed in SVN of revision 2430