PDA

View Full Version : Sencha Touch 2.0 PR1-patches repository



olouvignes
4 Nov 2011, 5:12 PM
I'm using ST 2.0 for production purposes since this early release & a few critical things were broken, i had to come up with some quick&dirty patches to make things work.

Since I do not know when PR2 is gonna come, i've put my patches on a github repo (hope it does not break any ST license). You can find it there :

https://github.com/mgcrea/sencha-touch

Patches :
- Fix Ext.List group headers duplicates.
- Fix z-index concatenation on Anim.run
- Fix crash when disabling sliderfield.
- Fix animations for IOS<5.0.


There is only debug-with-comments, you can compress it there : http://ganquan.info/yui/ (using Paste URL).

Hope it helps.

mitchellsimoens
5 Nov 2011, 5:49 AM
Why are you distributing the entire lib? Why not a set of overrides to patch? Then you wouldn't have to worry about licensing problems.

SunboX
5 Nov 2011, 7:25 AM
I think in "production" no one has time to build patches or apply them. ;o)

mitchellsimoens
5 Nov 2011, 7:29 AM
I think in "production" no one has time to build patches or apply them. ;o)

But when PR2 comes out and then other PR and then beta and then RC and the GA... you can remove patches as they get fixed.

I think in "production", you shouldn't use anything but GA, even then, you probably will still have patches even if it's not to fix a bug but to change behavior to suit your needs.

SunboX
5 Nov 2011, 7:31 AM
We used the PR1 in "production" to build a dummy for presentation next week (and checked if it "will work"). This will hopefully result in an job next year. ;o)

olouvignes
5 Nov 2011, 7:38 AM
When i say "production", i just mean that my work is supposed to get used by people/clients, that's all. I'm new to ST, & i can't imagine starting with 1.x - high risk / high reward i guess.

Indeed, the point is to reset this repo at each release & re-apply fixes that are still needed (ideally none).

About the whole lib issue, the point is that this repo is what I use, so it does not cost me time to make it public so it can help other early adopters. And i would love to rally some other early-adopters that would get their hands dirty (with pull requests & such).

I think this could also help the team (quicker fixes to common issues).

robl
5 Nov 2011, 10:41 AM
I don't think it's legal for you to redistribute their code even though it's helpful to others. For that reason alone, I would just provide 'diffs'.

dobie_
8 Nov 2011, 1:31 PM
Legal or not, this is very useful. Thanks olouvignes (http://www.sencha.com/forum/member.php?326813-olouvignes)!