PDA

View Full Version : ST2 community patches repository



dobie_
10 Nov 2011, 1:53 PM
The previous thread was closed... could a mod clarify why?

https://github.com/mgcrea/sencha-touch

lylepratt
11 Nov 2011, 11:36 AM
Its probably because you are distributing the full ST library which is probably against the licensing agreement. I believe Mitchell said something similar in your previous post.

You should instead publish your changes Patches, Diffs, or Overrides. Modifying the core source of any library is generally bad practice as it makes staying up to date, applying, or unapplying the changes cumbersome as the core library team releases updates and fixes.

I for one would not consider using your changes just because it directly modifies the source.

dobie_
11 Nov 2011, 12:14 PM
Under the open source license: http://www.sencha.com/legal/open-source-faq/
S (http://www.sencha.com/legal/open-source-faq/)encha actually states that they encourage posting patches to the Sencha forums, so I'm confused.

As far as distributing the entire source instead of just the diffs.. All the diffs are listed in the Github commits section: https://github.com/mgcrea/sencha-touch/commits/master
A (https://github.com/mgcrea/sencha-touch/commits/master)nd the library is freely available for anyone to download from sencha.com, so what's wrong with making it available at different places around the Internet? Surely the Sencha team isn't able to keep track of all the places their javascript library is on the web.

lylepratt
11 Nov 2011, 12:20 PM
Distributing the entire library is entirely different from distributing patches that you have written.

Item 4, first sentence:
http://www.sencha.com/legal/touch-commercial-license

I'm not saying the patches you have written are not beneficial, I'm just guessing why the admins closed your thread and suggesting an alternate, much more accommodating way you could have posted your beneficial changes.

Jamie Avins
11 Nov 2011, 2:53 PM
I've re-opened the thread. I don't think it's the best way to go, but we'll leave it to you.

olouvignes
14 Nov 2011, 4:31 AM
Again, this repo only aims at helping early adopters with blocking bugs preventing them to move to ST2.0, i guess the more people start using ST2.0 today, the more this (amazing) product gets a strong footprint on the web.

I would rather publish plugins & extensions, but for now we are quite stuck with blocking bugs.

I understand that this conflicts somehow with the global/commercial policy your company has, and i'm thankful i've not been asked to take it down yet, as I really think it is good for everyone at the moment.

It is not aimed to last beyond beta, and it will be taken down if you want it to (your product / business -> your call).

Regards,