Boolean Conversion

[adamatvips]

The default behaviour of Sencha Touch for converting to boolean doesn't match that of javascript which caused some issues in our code.

Switching the BOOL function of Ext.data.Type to the code below fixed our issue and seems more intuitive.




BOOL: {
convert: function (v) {
if (this.useNull && (v === undefined || v === null || v === '')) {
return null;

return !!v;
},
sortType: st.none,
type: 'bool'
}


Any chance of getting this into Sencha Touch 2 before release?

Cheers,
Adam

[mitchellsimoens]

Thanks for the report.

[TommyMaintz]

I have updated it to be the following (still converting to false if the value is 'false')



convert: function(v) {
if (this.useNull && (v === undefined || v === null || v === '')) {
return null;
}
return (v !== 'false') && !!v;
},


This will be part of the next release of Touch 2.0

[adamatvips]

I don't think this happend, we still have to override using this:

Ext.data.Types.BOOL.convert = function (value) {

if ((value === undefined || value === null || value === '') && this.getAllowNull()) {
return null;
}
return (value !== 'false') && !!value;

}

[Jamie Avins]

I'll reopen the issue so we can look into it again.

[TommyMaintz]

Hmm, for some reason the patch I had applied never made it into the code base. This has been fixed for the next release.