PDA

View Full Version : [Ext.BasicDialog].destroy(true) doesn't destroy shadow



diegovilar
25 Mar 2007, 12:13 PM
The title pretty much says it all.

If you invoke destroy(true) on an instance of Ext.BasicDialog which has shadows (argument true meaning that you want the corresponding DOM element to be destroyed as well), the dialog is destroyed but its shadow remains.

Ext 1.0 Alpha 3 rev 4

JeffHowden
25 Mar 2007, 12:42 PM
Indeed. The fix, is to check if the dialog has a shadow, if so, hide() it.

Here's an SVN path for it:


Index: BasicDialog.js
===================================================================
--- BasicDialog.js (revision 7)
+++ BasicDialog.js (working copy)
@@ -696,6 +696,9 @@
this.close.removeAllListeners();
this.close.remove();
}
+ if(this.shadow){
+ this.shadow.hide();
+ }
if(this.mask){
this.mask.remove();
}