PDA

View Full Version : [FIXED] incorrect height/layout for ToolBar and PagingToolBar



negge
24 Jun 2008, 7:06 AM
The height and layout of ToolBar and just height of PagingToolBar are wrong and inconsistent with extjs. The following patches fix them:


Index: user/src/com/extjs/gxt/ui/client/widget/PagingToolBar.java
===================================================================
--- user/src/com/extjs/gxt/ui/client/widget/PagingToolBar.java (revision 508)
+++ user/src/com/extjs/gxt/ui/client/widget/PagingToolBar.java (working copy)
@@ -552,8 +552,10 @@
toolBar.render(target, index);
setElement(toolBar.getElement());

- int h = XDOM.isVisibleBox ? 27 : 23;
- el().setHeight(h);
+ if (XDOM.isVisibleBox) {
+ el().setHeight(27);
+ }
+
}

}
Index: user/src/com/extjs/gxt/ui/client/widget/toolbar/ToolBar.java
===================================================================
--- user/src/com/extjs/gxt/ui/client/widget/toolbar/ToolBar.java (revision 508)
+++ user/src/com/extjs/gxt/ui/client/widget/toolbar/ToolBar.java (working copy)
@@ -153,11 +153,13 @@

addStyleName(baseStyle + " x-small-editor");
setStyleAttribute("paddingRight", "8px");
-
- int h = XDOM.isVisibleBox ? 28 : 23;
- el().setHeight(h);

+ if (XDOM.isVisibleBox) {
+ el().setHeight(28);
+ }
+
TableRowLayout layout = new TableRowLayout();
+ layout.setCellSpacing(0);
setLayout(layout);
layout();Nathan

darrellmeyer
24 Jun 2008, 7:39 AM
Fix is in SVN.

jraue
14 Jul 2008, 2:53 AM
I still have issues with a ToolBar with 20px height, see seperate post http://extjs.com/forum/showthread.php?t=41216.

Joachim