PDA

View Full Version : [FIXED] ToolBar Redering Issue



jraue
14 Jul 2008, 2:43 AM
Hi,

on two instances, I use a toolbar with a height of 20px and face some rendering issues that occasionally render by toolbar with a height of 25px.

My classes derive from ToolBar. Looking into the code, I noticed the onRender method:



protected void onRender(Element target, int index) {
setElement(DOM.createDiv(), target, index);

addStyleName(baseStyle + " x-small-editor");
setStyleAttribute("paddingRight", "8px");

if (XDOM.isVisibleBox) {
setHeight(25);
}

TableRowLayout layout = new TableRowLayout();
layout.setCellSpacing(0);
setLayout(layout);
layout();

}
Is there a reason that 25 is written hard-coded there? I believe this might be the cause for the issues I experience. If not, what would be your recommendation to use ToolBar with a height other than 25px?

Thanks,

Joachim

darrellmeyer
14 Jul 2008, 7:54 PM
I have removed the hard coded height and made a few CSS changes for IE. With the changes, no height is set either in code or CSS.

jraue
14 Jul 2008, 9:39 PM
Thanks, Darrell!