[CLOSED] BaseModelData NPE silently

[Kutu]

The following line is in BaseModelData get(String property):



return map == null ? null : (X) map.get(property);
This seems to fail silently because if the return value of map.get(property) is null, converting to (X) will fail (my guess)

Maybe it should return null as well if map.get() is null before type-casting to (X).

[zaccret]

I don't think so. A cast from null value to X won't fail.

[darrellmeyer]

zaccret is correct:


public void onModuleLoad() {
ModelData m = new BaseModelData();
String s = m.get("foo");
if (s == null) {
System.out.println("no problem");
}
}