PDA

View Full Version : [FIXED][3.x/2.x] EditorGridPanel::onAutoEditClick



Animal
5 Aug 2008, 11:41 PM
The config clicksToEdit: 'auto' is undocumented now (I just added the docs for it to SVN), so this bug will not be manifesting (Except for people who read the source who will be able to work around it anyway)

But there's a problem in onAutoEditClick which throws an exception which is handled silently which just aborts editing.

The code should be



onAutoEditClick : function(e, t){
if(e.button !== 0){
return;
}
var row = this.view.findRowIndex(t);
var col = this.view.findCellIndex(t);
if(row !== false && col !== false){
this.stopEditing();
if(this.selModel.getSelectedCell){ // cell sm
var sc = this.selModel.getSelectedCell();
if(sc && sc[0] === row && sc[1] === col){
this.startEditing(row, col);
}
}else{
if(this.selModel.isSelected(row)){
this.startEditing(row, col);
}
}
}
},

Condor
24 Jun 2009, 10:36 PM
Why is this thread marked as fixed?

It doesn't seem to be fixed in either Ext 2.x or 3.x.

mystix
24 Jun 2009, 10:49 PM
no idea why the thread was marked [FIXED], but i renamed the thread to read [OPEN] since it's clearly not resolved yet.

evant
25 Jun 2009, 12:18 AM
Actually fixed. Both branches.