[ACC] ComboBox prepareData reference pass to data view

[jay@moduscreate.com]

It seems we can pass an item selector for the dataview for a given combo box, but cannot override the prepare data method. Ideally, there should probably be a 'dataviewcfg' or 'viewcfg' object that we pass instead of having them inline.




#line 71
this.view = new Ext.DataView({
applyTo: this.innerList,
tpl: this.tpl,
singleSelect: true,
selectedClass: this.selectedClass,
prepareData : this.prepareData || null, //<<--- addition
itemSelector: this.itemSelector || '.' + cls + '-item'
});




I can now easily have an image based dataview for a drop down box like in the examples for data view ;)

[Condor]

Does the 'null' really work?

Wouldn't it be better to use:

this.view = new Ext.DataView({
applyTo: this.innerList,
tpl: this.tpl,
singleSelect: true,
selectedClass: this.selectedClass,
prepareData : this.prepareData || Ext.DataView.prototype.prepareData,
itemSelector: this.itemSelector || '.' + cls + '-item'
});
or

this.view = new Ext.DataView({
applyTo: this.innerList,
tpl: this.tpl,
singleSelect: true,
selectedClass: this.selectedClass,
itemSelector: this.itemSelector || '.' + cls + '-item'
});
if(this.prepareData){
this.view.prepareData = this.prepareData;
}

[mystix]

i'd rather take his other suggestion (and the easy way out):


this.view = new Ext.DataView(Ext.apply({
combo: this, // and while we're at it, let's give the internal DataView a reference to its parent ComboBox
applyTo: this.innerList,
tpl: this.tpl,
singleSelect: true,
selectedClass: this.selectedClass,
itemSelector: this.itemSelector || '.' + cls + '-item'
}, this.viewConfig));

[jay@moduscreate.com]

@condor:
The point of these posts is not to have the dev team take the code verbatim, but rather provide some sort of guidance as to what i'm talking about. That said, I believe they would get the point.

I extended combo to do this at my main gig with great results.

I really like the idea of having a 'veiwConfig' object litteral, and am going to modify this custom extension to accept and apply it.

[Animal]

+1 for the viewConfig config option which is applied to the configuration of the DataView.

[jay@moduscreate.com]

one last friendly bump for visibility :)