PDA

View Full Version : [OPEN] [FIXED][3.0] Grid ColumnModel text items missing from locale files



Animal
14 Feb 2009, 8:00 AM
In src/widgets/grid/Column.js:



Ext.grid.BooleanColumn = Ext.extend(Ext.grid.Column, {
/**
* @cfg {String} trueText
* The text used
*/
trueText: 'true',
falseText: 'false',
undefinedText: '�',

constructor: function(cfg){
this.supr().constructor.apply(this, arguments);
var t = this.trueText, f = this.falseText, u = this.undefinedText;
this.renderer = function(v){
if(v === undefined){
return u;
}
if(!v || v === 'false'){
return f;
}
return t;
};
}
});


Needs an extra section in the locale files:



if(Ext.grid.BooleanColumn){
Ext.apply(Ext.grid.BooleanColumn.prototype, {
trueText : "true",
falseText : "false"
});
}

And DateColumn should used the localized renderer which is configured into Ext.util.Format by the locale file rather than generating another renderer using 'm/d/Y'. Code should be:



Ext.grid.DateColumn = Ext.extend(Ext.grid.Column, {
constructor: function(cfg){
this.supr().constructor.apply(this, arguments);
this.renderer = Ext.util.Format.date;
}
});

Animal
1 Mar 2009, 12:10 PM
Column class still contains these problems.

Animal
15 Jun 2009, 12:04 PM
Last bump before 3.0 release!

evant
19 Jun 2009, 2:57 AM
They've been added to the default locale file. Obviously the rest of them need to be filled with the appropriate content.

mjlecomte
19 Jun 2009, 7:15 AM
Should we add some kind of locale thread that we can bump when something in the locale directory changes? That way people can subscribe to it and then contribute their updates? I'm not sure how that has worked in the past.

mystix
19 Jun 2009, 7:22 AM
Should we add some kind of locale thread that we can bump when something in the locale directory changes? That way people can subscribe to it and then contribute their updates? I'm not sure how that has worked in the past.

there used to be a stickied Translations thread in the Open Discussion Forum for that purpose.

mystix
19 Jun 2009, 7:24 AM
alritey, managed to find it:
60839