PDA

View Full Version : [FIXED][3.0] TriggerField / r2213 and IE8



stever
8 Apr 2009, 8:27 PM
Jack put in r2213 before IE8 was out to deal with some IE problems apparently. However, in IE8 it messes up twin trigger fields that I have created. Perhaps it should be limited to IE6 and IE7. Which works for me. Thanks!


afterRender : function(){
Ext.form.TriggerField.superclass.afterRender.call(this);
var y;
if((Ext.isIE6||Ext.isIE7) && !this.hideTrigger && this.el.getY() != (y = this.trigger.getY())){
this.el.position();
this.el.setY(y);
}
}


In addition: the CSS fixes for the ie bogus margin bug should be restricted to IE6 and IE7 in form.css:


.ext-ie6 .x-small-editor .x-form-text,.ext-ie7 .x-small-editor .x-form-text {
margin-top:-1px !important; /* ie bogus margin bug */
margin-bottom:-1px !important;
height:20px !important; /* ie quirks */
line-height:16px !important;
}


.ext-ie6 .x-form-text,.ext-ie7 .x-form-text {
margin:-1px 0; /* ie bogus margin bug */
height:22px; /* ie quirks */
line-height:18px;
}


.ext-ie6 textarea.x-form-field,.ext-ie7 textarea.x-form-field {
margin:-1px 0; /* ie bogus margin bug */
}

stever
9 Apr 2009, 2:50 PM
Someone ought to take a look at these IE specific css rules and see which are needed for IE8 and which are not. I stumbed across that when I accidentally took out the ext-ie class from the body and everything that was off suddenly looked good! Not a thorough test, of course but did get me looking at the ext-ie CSS code...

evant
9 Apr 2009, 3:20 PM
I'm checking out the form related stuff in IE8 now. Once the margin bug is fixed for text fields, it looks mostly ok.

stever
14 Apr 2009, 8:30 PM
This is marked as fixed, but the afterRender function is still IE version indiscriminate. Which might be on purpose, just don't think it is...