PDA

View Full Version : [FIXED][Core 3.0 beta] global var stuff



bas_denis
9 Apr 2009, 11:15 PM
this should fix those global var mistakes for the downloadable version of today
(ext-core-3.0-beta1.zip, Ext Core Library 3.0 Beta, Ext = {version: '3.0'};)


line 1416

anim = new type(el, args, duration, EXTLIB.Easing[easing] || easing);
should be

var anim = new type(el, args, duration, EXTLIB.Easing[easing] || easing);



line 3065

ISOBJECT = Ext.isObject
should be

ISOBJECT = Ext.isObject,



line 4540

h = (s * 1).toString(16);
should be

var h = (s * 1).toString(16);



line 4999

style.display = NONE;
should be (as i think)

me.dom.style.display = NONE;



line 5001

style.visibility = HIDDEN;
should be (as i think)

me.dom.style.visibility = HIDDEN;



line 5537

var r = me.getFxRestore();
should be

var r = me.getFxRestore(),



line 5539

h = me.getHeight();
should be

h = me.getHeight(),

that was the global var stuff


for line 6014

return o.callback ? o.callback.apply(o.scope, [o,,]) : null;
it would be more elegante to write (if those 2 undefined are wanted)[as i think]

return o.callback ? o.callback.apply(o.scope, [o,undefined,undefined]) : null;



hope it helps,
nice work, indeed.
and keep it clean :D

evant
9 Apr 2009, 11:28 PM
Agreed, thanks for those, I've commited your changes into svn.