PDA

View Full Version : [FIXED][3.0rc1] row editor doesn't work in IE Quirks mode



wopenonline111
15 Apr 2009, 7:30 AM
row editor doesn't work in IE7 and IE8

http://extjs.com/deploy/ext-3.0-rc1/examples/grid/row-editor.html

Condor
15 Apr 2009, 7:33 AM
Clarification, it doesn't work for IE quirks mode (IE version independant).

evant
15 Apr 2009, 1:34 PM
Confirmed for quirks mode, thanks.

aconran
5 May 2009, 12:36 PM
Try this override to resolve the RowEditor issue in quirks mode. I don't feel happy about the magic numbers, but hey it works. This has not been committed yet.



Ext.ux.RowEditor.override({
verifyLayout: function(force){
if(this.el && (this.isVisible() || force === true)){
var row = this.grid.getView().getRow(this.rowIndex);
this.setSize(Ext.fly(row).getWidth(), Ext.fly(row).getHeight() + (Ext.isBorderBox ? 9 : 0));
var cm = this.grid.colModel, fields = this.items.items;
for(var i = 0, len = cm.getColumnCount(); i < len; i++){
if(!cm.isHidden(i)){
var adjust = 0;
if(i == 0){
adjust += 0; // outer padding
}
if(i == (len - 1)){
adjust += 3; // outer padding
} else{
adjust += 1;
}
fields[i].show();
fields[i].setWidth(cm.getColumnWidth(i) - adjust);
} else{
fields[i].hide();
}
}
this.doLayout();
this.positionButtons();
}
}
});

aconran
5 May 2009, 1:01 PM
Committed the above fix to SVN as of revision 3892.

Please bump if you see any other issues.

Luc
3 Jun 2009, 1:29 PM
Row editor not working in this sample:

http://extjs.com/deploy/ext-3.0-rc2/examples/restful/restful.html

Windows XP/IE7

aconran
3 Jun 2009, 4:06 PM
An old version fo the RowEditor was included in the restful sample. Please try again.

Luc
4 Jun 2009, 2:40 AM
I tried new version (I have script error alerts enable in IE7):

I get JS error:

Line: 62
Error: Object expected

The form and grid don't render at all.

aconran
4 Jun 2009, 4:31 AM
One last time? Path was bad. ;)