PDA

View Full Version : [FIXED][3.0RC1] Combobox Transform Bug



next
21 Apr 2009, 4:22 AM
Found a small combobox bug that prevents the DOM selected option to get selected in the transformed combobox.



initComponent: function() {
// ...
if(o.selected && !Ext.isEmpty(this.value, true)) {
this.value = value;
}
// ...
}


should be:



initComponent: function() {
// ...
if(o.selected && !Ext.isEmpty(value, true)) {
this.value = value;
}
// ...
}

evant
21 Apr 2009, 6:22 AM
This is the intended behaviour. The assumption is that if you're transforming a combo AND specifying a value, you want to override the selected value in the transformed box.

Am I missing something?

Condor
21 Apr 2009, 6:27 AM
This is the intended behaviour. The assumption is that if you're transforming a combo AND specifying a value, you want to override the selected value in the transformed box.

Am I missing something?

But in that case shouldn't the code be:

initComponent: function() {
// ...
if(o.selected && /*!*/Ext.isEmpty(this.value, true)) {
this.value = value;
}
// ...
}

evant
21 Apr 2009, 6:48 AM
Indeed. Committed.