PDA

View Full Version : [FIXED] [1.2.3, 2.0m1] ComboBox.setPropertyEditor assertion gives incorrect advice



Curt Arnold
27 Apr 2009, 3:19 PM
In both 1.2.3 and 2.0 M1, ComboBox.setPropertyEditor asserts that the property editor must be a ListModelPropertyEditor, but tells the developer it needs to be just a ModelPropertyEditor.

Current code looks like:

public void setPropertyEditor(PropertyEditor<D> propertyEditor) {
assert propertyEditor instanceof ListModelPropertyEditor : "PropertyEditor must be a ModelPropertyEditor instance";
super.setPropertyEditor(propertyEditor);
}

Should be:

public void setPropertyEditor(PropertyEditor<D> propertyEditor) {
assert propertyEditor instanceof ListModelPropertyEditor : "PropertyEditor must be a ListModelPropertyEditor instance";
super.setPropertyEditor(propertyEditor);
}

sven
28 Apr 2009, 2:49 AM
Fixed in SVN.