PDA

View Full Version : [FIXED][3.0 Core rev 280] DelayedTask broken



Condor
1 May 2009, 12:24 AM
The last update to DelayedTask (rev. 280) removed NULL = null, but still left in id = NULL.

ps. Using NULL = null does save some bytes in compression, so why was it removed?

Animal
1 May 2009, 12:30 AM
I think A few more bytes can be removed from that code too...



me.delay = function(delay, newFn, newScope, newArgs){
this.cancel();
fn = newFn || fn;
scope = newScope || scope;
args = newArgs || args;
id = setInterval(call, delay);
};


this.cancel checks and clears the id, so no need to do it in delay.

evant
1 May 2009, 1:00 AM
NULL = null was removed because it wasn't really saving anything if there's only 2 instances of it. I had meant to remove the id = NULL part.

Fixed in SVN.