PDA

View Full Version : [FIXED][3.0 SVN] buttonAlign does not understand right



Lloyd K
7 May 2009, 6:13 AM
buttonAlign seems to ignore "right" as an option. It understands "left" and "center" however.



var window = new Ext.Window({
title: "...",
width: 400,
height: 300,
constrain: true,
plain: true,
border: false,
closable: false,
layout: "border",
items: [{
region: "north",
height: 10,
margins: "0 0 5 0"
},{
xtype: "form",
region: "center",
border: true,
bodyStyle: "padding:24px;background-color:transparent;",
items: [{
xtype: "textfield",
fieldLabel: "Username",
anchor: "100%"
}],
buttonAlign: "right",
buttons: [{
text: "ABC"
},{
text: "123"
}]
}]
});

evant
7 May 2009, 6:24 AM
Browser?

Lloyd K
7 May 2009, 6:27 AM
Curious. Initially I tried it on Firefox 2 which isn't working. I then tried it on Chrome and it was aligned tooo right and off the window area. IE8 seems fine with it as does Opera.

Actually, when I resize the window in Chrome it then renders properly.

evant
8 May 2009, 1:00 AM
Confirmed only in FF2, fine in webkit browsers.

Lloyd K
8 May 2009, 1:07 AM
Hmmm this is what I meant by Chrome:

http://www.lloydkinsella.net/forumbin/0081.png

It fixes itself when I resize but renders initially like that. As you can see the buttons are off the right edge for some reason.

aconran
19 May 2009, 8:05 AM
I could not reproduce any issues in Chrome in the SVN build.

I committed a fix for Firefox 2 - revision 3977 for the buttonAlign: 'right' issue.

Lloyd K
20 May 2009, 1:38 AM
Yep I can confirm it's fixed AND that the Chrome issue has also gone away.

watrboy00
6 Jun 2009, 10:51 PM
Evan's SVN commit (#4089) removes the fix Aaron had put it. Still an issue in FF2.

Lloyd K
29 Jun 2009, 12:34 AM
This issue is still outstanding :/

mystix
29 Jun 2009, 12:54 AM
confirmed -- tried test case from post #1 against the latest 3.x SVN and it still doesn't right-align buttons in FF2.0.0.20.

this is caused by the following css rule:


x-toolbar-ct{width:100%;}


adding the following css rule resolves the issue:
(modified from existing rule for .x-panel-btns-center .x-toolbar-ct)


.x-panel-btns-right .x-toolbar-ct {width:auto;}


p.s. test case works fine in FF3.0.11 / Chrome 3 without the new rule.

evant
30 Jun 2009, 7:30 AM
Fixed for FF2 in SVN.