PDA

View Full Version : [FNR] ModalPanel size



Colin Alworth
8 Jun 2009, 1:53 PM
Seems that the ModalPanel is being sized incorrectly when you have a Dialog that is modal. Looking at ModalPanel.syncModal(), the bug is pretty obvious (line numbers from trunk):

170: public void syncModal() {
171: int w = XDOM.getViewWidth(true);
172: int h = XDOM.getViewWidth(true);
173: setSize(w, h);
174: }If the page can be scrolled, this shows up quickly - scroll down too far, and the mask disappears. If 172 sets h to XDOM.getViewHeight(true) instead, this issue doesn't happen.

sven
8 Jun 2009, 2:01 PM
Yes you are right. Thanks for reporting.

We optimized the method a little bit. Will be fixed with the next commit.

sven
8 Jun 2009, 2:08 PM
Fixed in SVN

Colin Alworth
8 Jun 2009, 2:24 PM
Man, you guys are on fire today... Any chance I can redirect you to some of my older (http://extjs.com/forum/showthread.php?t=68531) bugs (http://extjs.com/forum/showthread.php?t=69069)?

We really do appreciate the rapid response - keep it up!