PDA

View Full Version : [FIXED] Dragging a TreePanel parent to it's child is allowed



Colin Alworth
17 Jun 2009, 12:41 PM
This can be trivially reproduced in the samples - on the reordering tree (http://extjs.com/examples-dev/explorer.html#reorderingtree) page, drag and drop any folder node on another folder node. Then open the now-parent node, and drag that node on to its new child.

Another variation: Drag a node onto itself. It will disappear, instead of staying where it is.

These are both in Firefox - If you open the same page in IE, and drag a node onto another node. Drag it back out again, and text starts to stack. This is harder to consistently reproduce, and mousing over affected cells appears to fix them. Best steps we have so far: Drop Grids into TreeGrid, then drop Grids into TreePanel.

Note that I have not attempted this in the trunk, only in the m3 pre-release.

Colin Alworth
18 Jun 2009, 12:52 PM
Attached an image of the IE issue, where dragging and dropping nodes mangles the text.

sven
18 Jun 2009, 1:01 PM
We already have a fix for the stacked nodetexts ready. Will be fixed in SVN soon

sven
23 Jun 2009, 1:46 PM
Fixed in SVN

Colin Alworth
23 Jun 2009, 2:01 PM
The primary bug is not yet fixed here, where nodes can be dropped into their own children, and thus removed from the tree. I don't see how to mark this thread as not FNR, can you confirm that this bug still present or re-open the thread?

Issue can still be reproduced on http://extjs.com/examples-dev/explorer.html#reorderingtree

p.s. I can confirm that the mangled text issue does appear fixed.

darrellmeyer
24 Jun 2009, 6:32 AM
Dropping nodes on itself or any of it's children is now not allowed. I have also added the valid append drop style (green background) while hovering.

Can you validate at http://extjs.com/examples-dev/explorer.html#reorderingtree

Colin Alworth
26 Jun 2009, 7:11 AM
Yep - looks good. We're moving today to the new RC, and very much looking forward to final!