PDA

View Full Version : Lightbox example broken?



DigitalSkyline
30 Jun 2009, 8:25 PM
http://extjs.com/playpen/ext-core-latest/examples/lightbox/

Close button only hides the mask, doesn't hide picture/controls .

Using FF 3.5

mankz
30 Jun 2009, 10:10 PM
Fixed in SVN: https://extjs.com/forum/showthread.php?t=71252

Still weird to leave it broken on the samples page, not a very good first impression for new users...

BKrisz79
30 Jun 2009, 10:55 PM
Please somebody tell me how can I download an SVN version. I tried to look the above mentioned link (and many other link) but I couldn't find how to download it. Thnx any response.

DigitalSkyline
30 Jun 2009, 11:14 PM
No support subscription means no SVN access.

andycramb
1 Jul 2009, 1:03 AM
Can you fix the tabs in SVN as well?
Ncesky reported in this thread (http://extjs.com/forum/showthread.php?t=72232)that the tabs are not behaving as you would expect.


I found that in examples/tabs/tabs.js the function uses flyweight to radioClass tab-show to the appropriate tab element. The function works correctly when updated to use Ext.get instead of Ext.fly, but I don't understand what the issue with flyweight is... change line 30:

Ext.fly(t).radioClass('tab-show'); to Ext.get(t).radioClass('tab-show');Clicking on the "Vehicles" tab displays the "Animal" tab but the correct content for the "Vehicles" tab


From a UI perspective the focused tabs could do with being "unclickable" as well.


Still weird to leave it broken on the samples page, not a very good first impression for new users...I agree. Maybe they have lot going on with the push for the latest release.

mystix
1 Jul 2009, 1:53 AM
i just tested that example against the latest 3.0 Core build from SVN (in both Firefox 3.5 and Chrome 3) and can confirm that it's already been fixed.

hello2008
1 Jul 2009, 2:04 AM
i just tested that example against the latest 3.0 Core build from SVN (in both Firefox 3.5 and Chrome 3) and can confirm that it's already been fixed.

sounds good, thanks;)

DigitalSkyline
2 Jul 2009, 5:41 PM
I'm surprised that such blatant bugs would be released in a "final" package and it not be a top priority to be fixed. I understand being busy but how long could it possibly take to post an updated version?

aconran
3 Jul 2009, 7:25 AM
We will be releasing Ext Core 3.0.1 as well as the public SVN details for Ext Core soon.

aconran
3 Jul 2009, 7:40 AM
Public read-only access to Ext Core:
http://code.extjs.com/svn/ext-core/trunk/

DigitalSkyline
3 Jul 2009, 8:52 AM
Now You're Talking!!!! Thanks, for renewed faith!

mystix
3 Jul 2009, 8:59 AM
Public read-only access to Ext Core:
http://code.extjs.com/svn/ext-core/trunk/

@aaron, might want to put that up over at the download page:
http://extjs.com/products/extcore/download.php

abe.elias
3 Jul 2009, 11:51 AM
http://extjs.com/products/extcore/download.php

Refresh :)

Now with a public easy to view commit log as well.

hello2008
4 Jul 2009, 9:02 PM
Great! Thanks team ;)

steffenk
5 Jul 2009, 1:49 AM
one bug is left, i posted it in the Bugs forum (height of mask)

Edit: solution is found. May a core dev have a look?

links
5 Jul 2009, 3:54 PM
I've also found a bug with overlaying in FF 3.5. A flash object is not overlayed by the mask. In IE7 it works ok.

Regards

careprad
21 Jul 2009, 11:27 PM
there is another bug in ie,


line300:els.details.setWidth((els.data.getWidth(true) - els.navClose.getWidth() - 10) + 'px');
if the image's width is little,then the expression will result in a minus width,it will broken in IE.