PDA

View Full Version : [2.0] hardcoded I18N ( XMessages )



Arno.Nyhm
23 Jul 2009, 9:07 AM
i have found this possible wrong definitions of I18N and it should be moved to XMessages or use the default values:


RowEditor.java:318: showTooltip("You need to commit or cancel your changes");

NumberPropertyEditor.java:32 protected String currencySymbolRegex = "\\$";
NumberField.java:142 private String decimalSeparator = ".";
ComboBox.java:207 private String loadingText = "Loading...";
ListView.java:111 private String loadingText;
DatePicker.java:89 private String okText = " OK ";
TreePanelDragSource.java:34 setStatusText("{0} items selected");
TreeGridDragSource.java:34 setStatusText("{0} items selected");
TreeDragSource.java:44 setStatusText("{0} items selected");
ListViewDragSource.java:38 setStatusText("{0} items selected");
TaskBar.java:141 setText("Start");
NOTE: for the currencySymbol it should be also handle both currency symbols ($ and USD / € and EUR)



this should be solved as css!?

Legend.java:55 setBackgroundColour("#fefefe");in the description "setup.txt" it looks i can move and rename this file as i like. but here it is hardcoded - a possible bug:

CSS.java:59 if (href.length() != 0 && href.indexOf("gxt-all.css") != -1) {

Colin Alworth
23 Jul 2009, 12:23 PM
Seconded - I have simply reset a few of these strings, but they bloat the final js size, so properly abstracting these to interfaces would be the preferred solution.

Arno.Nyhm
24 Jul 2009, 4:08 AM
Seconded - I have simply reset a few of these strings, but they bloat the final js size

can you provide some codesnippets how to do this?



so properly abstracting these to interfaces would be the preferred solution.

can you also point me to some howto or some codesnippets how to do this, because i dont know what you mean exactly (sorry).

sven
24 Jul 2009, 11:17 AM
Legend.java:55 setBackgroundColour("#fefefe");

This cant be done as css class.



I changed a couple of the other things already in SVN.