PDA

View Full Version : [FIXED-444][3.1.1-beta] renderAll function is missing



nextdigital
17 Jan 2010, 10:20 PM
r5895 has broken alot of my doLayout() calls with the error:

c.renderAll is not a function

I would love to test the beta more for you, but for now I'll have to rollback

evant
17 Jan 2010, 10:26 PM
That's not really enough information, can you please elaborate?

nextdigital
17 Jan 2010, 10:47 PM
Container.doLayout() is failing on line 814 because the component's layout is still a config and hasnt been created.



c.renderAll(this, this.getLayoutTarget());


using firebug I can see that c = {type: 'hbox', align: 'stretch'}

Jamie Avins
18 Jan 2010, 9:31 AM
Yes, it should be checking to see if the container is rendered, something that was missed when doLayout was re-merged from deepRender. I'll get that put back in shortly.

Jamie Avins
18 Jan 2010, 10:40 AM
Fixed in svn 5906. In these cases you are trying to call doLayout on a container that hasn't been rendered yet. Previous versions checked to make sure the container was at least rendered before trying to render the container's children. This check is now back in place.