PDA

View Full Version : textarea onDestroy incorrect Ext.Element reference



mdissel
11 Jul 2007, 4:49 AM
In the TextArea.onDestroy the code will try to remove the textSizeEl element, but that variable contains a reference to a dom node and not a reference to a Ext.Element, thus remove() does not work..

In the onRender the DomHelper.append is called without the extra parameter to return an Ext.Element..

Shouldn't the DomHelper.append return an Ext.Element by default (equal to Ext.Element functions)?

ps. code 1.1 and 2.0 both have this bug.

Thanks

Marco

jack.slocum
11 Jul 2007, 11:42 AM
I will commit a correction shortly.

I try to use Ext.Element only where needed. n this particular case Ext.Element functionality wasn't needed so I used the raw dom node.

DomHelper returning an Ext.Element as the default (instead of having to pass true) would in fact be nice, but breaking the amount of code (both in Ext and users code) that uses DomHelper is not a good idea IMHO. ;)

mdissel
11 Jul 2007, 12:26 PM
DomHelper returning an Ext.Element as the default (instead of having to pass true) would in fact be nice, but breaking the amount of code (both in Ext and users code) that uses DomHelper is not a good idea IMHO. ;)

I agree

Thanks

Marco