PDA

View Full Version : [FIXED-515][3.1.1 rc] Ext.Toolbar#enableOverflow (patch)



uwolfer
2 Feb 2010, 12:24 AM
The documentation tells that Ext.Toolbar#enableOverflow is false by default. This is not true; it's not initialized at all. This has the result that the check "this.container.enableOverflow === false" returns false and performance expensive dom operations are executed (Firebug profiler tells about 10% in my case).

The following override fixes this issue:


Ext.override(Ext.Toolbar, {
enableOverflow: false
});

uwolfer
3 Feb 2010, 3:05 AM
It looks like you have changed something in this area for 3.1.1 RC. Though it does not fix the issue in a global way. Why don't you use my override, which would fix it?

evant
3 Feb 2010, 3:09 AM
Jamie did exactly that, in rev 5978.

Jamie Avins
3 Feb 2010, 9:14 AM
Thanks Evan, I forgot to post it is now in SVN 5978.