PDA

View Full Version : [DUPE-519][3.1] HTMLEditor setReadOnly() toolbar disable toggle is backwards



damon1977
2 Feb 2010, 10:05 AM
I don't know if this has been fixed for 3.1.1 yet, but in 3.1.0...



setReadOnly: function(readOnly){
if(this.initialized){
var newDM = readOnly ? 'off' : 'on',
doc = this.getDoc();
if(String(doc.designMode).toLowerCase() != newDM){
doc.designMode = newDM;
}
this.disableItems(!readOnly);
}
Ext.form.HtmlEditor.superclass.setReadOnly.call(this, readOnly);
},
should be...




setReadOnly: function(readOnly){
if(this.initialized){
var newDM = readOnly ? 'off' : 'on',
doc = this.getDoc();
if(String(doc.designMode).toLowerCase() != newDM){
doc.designMode = newDM;
}
this.disableItems(readOnly);
}
Ext.form.HtmlEditor.superclass.setReadOnly.call(this, readOnly);
},

Jamie Avins
2 Feb 2010, 10:39 AM
This was fixed in svn 5901.