PDA

View Full Version : [CLOSED-550][3.1.x/3.2.x] Multi-row tabbing with IE 8 is broken due to css change



meroy
4 Feb 2010, 7:37 PM
Multi-row tabbing has been working fine. The other day, I noticed a problem under IE 8.

Use the test-case-5 tool from this post with IE 8:
http://www.extjs.com/forum/showthread.php?p=433554#post433554

Click "Add 10 Forms". Add enough tabs to cover 2 rows.

Now click on several tabs on the top row. Notice the blank area between the 2 rows.

It's been broken since rev 5945. Can this be fixed.


Thanks,
Mario

meroy
5 Feb 2010, 8:10 AM
Multi-Row tabbing was working with 3.1.0 and IE 8.
It's failing with 3.1.1-rc.
It began failing with rev 5945.

meroy
19 Feb 2010, 11:59 AM
Kind bump so this isn't forgotten.

Thanks.

meroy
22 Feb 2010, 1:11 AM
To fix this, I changed the following in resources/css/structure/tabs.css.

The line in red breaks multi-row tabbing.



/*
* Horrible hack for IE8 in quirks mode
*/
.ext-ie8 ul.x-tab-strip li {
position: relative;
}
.ext-ie8 .x-tab-strip .x-tab-right{
margin-bottom: 0 !important;
top: 1px;
}
.ext-ie8 ul.x-tab-strip-top {
padding-top: 0;
}
.ext-ie8 .x-tab-strip .x-tab-strip-closable a.x-tab-strip-close {
top:4px;
}


To this:



/*
* Horrible hack for IE8 in quirks mode
*/
.ext-ie8 ul.x-tab-strip li {
position: relative;
}
.ext-border-box .ext-ie8 .x-tab-strip .x-tab-right {
top: 1px;
}
.ext-ie8 ul.x-tab-strip-top {
padding-top: 1;
}
.ext-border-box .ext-ie8 ul.x-tab-strip-top {
padding-top: 0;
}
.ext-ie8 .x-tab-strip .x-tab-strip-closable a.x-tab-strip-close {
top:3px;
}
.ext-border-box .ext-ie8 .x-tab-strip .x-tab-strip-closable a.x-tab-strip-close {
top:4px;
}



Now, tabs work consistently with IE 8 including multi-row tabbing.

jayrobinson
25 Feb 2010, 10:30 AM
This is a non-standard implementation of tabs. We suggest you try scrolling tabs instead.

Thanks.

meroy
25 Feb 2010, 11:33 PM
No problem. I can use my fix in the meantime. This was working before.

Read this thread. Some apps will break out there.

http://www.extjs.com/forum/showthread.php?t=23660