Grid header filters

Quote:

---

Originally Posted by mshussein

Well,

I managed to work around this by changing this:

Code:

---

if(t=='combo' || t=='datefield'){ //avoid refresh twice for combo select
  return;
}else{
  this.applyFilter(field);
}

---

to

Code:

---

if(t=='combo' || t=='datefield'){ //avoid refresh twice for combo select
  this.applyFilter(field);
}else{
  this.applyFilter(field);
}

---

...inside the configure function (Changes were made around line 342).

I know it makes the if statement redundant, but it's easier to keep it like that so I can switch between the two.

Yet to find any issues with the change.

Regards,
mshussein.

---

Yes, this is a patch for this bad behaviour.
The applyMode = 'auto' or = 'change' is now deprecated, I always use applyMode = 'enter', adding also an "apply button" to my grid toolbar.
You can also use the filter configuration attribute "applyFilterEvent" to select the field event that applies filter. At the moment this feature is a little bit restrictive because you can specify only one event listener and it replaces any other listener specified in filter field config. That could be improved in future versions.

Hi,

please fix memory leak probably caused by typing error (filterContainer -> filterContainers). The this.filterContainer does not exist, so filterContainers' items are never destroyed. This is a very unpleasant bug since the destroyFilters function is executed almost after each action with the filter.

Code:

---

destroyFilters: function()
        {
                if(this.filterFields)
                {
                        for(var ff in this.filterFields)
                        {
                                Ext.destroy(this.filterFields[ff]);
                                delete this.filterFields[ff];
                        }
                }
               
                if(this.filterContainer)
                {
                        for(var ff in this.filterContainers)
                        {
                                Ext.destroy(this.filterContainers[ff]);
                                delete this.filterContainers[ff];
                        }
                }
               
        }

---

Quote:

---

Originally Posted by qwikso

Hi,

please fix memory leak probably caused by typing error (filterContainer -> filterContainers). The this.filterContainer does not exist, so filterContainers' items are never destroyed. This is a very unpleasant bug since the destroyFilters function is executed almost after each action with the filter.

---

Thanks for the fix.
I've updated the first page with latest version code.

Are there plans to support extjs 4?
Do you think many changes are required?

p.s. can you support disabled fields?
patch:
http://www.sencha.com/forum/showthre...l=1#post541074

Quote:

---

Originally Posted by dolittle

Are there plans to support extjs 4?
Do you think many changes are required?

p.s. can you support disabled fields?
patch:
http://www.sencha.com/forum/showthre...l=1#post541074

---

Hi,
I've applied your patch to the applyFilter method (with a little change):

Code:

---

...
if(el.disabled && !Ext.isDefined(this.grid.store.baseParams[el.filterName]))
  return;
       
var sValue = this.getFieldValue(el);

if(el.disabled || Ext.isEmpty(sValue))
{
  delete this.grid.store.baseParams[el.filterName];
  delete this.filters[el.filterName];
}
...

---

The latest version (2.0.6) is published on the first page of this thread.

About ExtJS 4: I have not tried it yet. I hope to do it soon while waiting for the final release.

Thanks.

Hello,

I have a problem when using a grid with header filters in a card layout.
This is what I have:

The first panel shows the grid. In my application I have an edit dialog for records in the grid.
In some cases I must reload the store when the grid is hidden.

In this case the filter fields in the header disappear completely when using version 2.0.5.
If I use version 2.0.6, the filter fields are minimized and the trigger is shown.

You can try it here:
http://sandbox.astuteq.de/


- go to the page
- press "reload"
- press "show grid"

source:
http://sandbox.astuteq.de/js/sandbox.js

Any ideas?

Thanks!

Stefan

I think there's a bug when resizing the columns, the width of the filter textfield/combo isn't calculated correctly. Instead of using absoulte values which need to be recalculated on every column resize, isn't it better to make the filter 100% width by default?

I have no width set. And it seems that it is the default setting to make the filter fields 100% of the column width?

Hello,

could somebody imagine a solution for the problem described in post #116?

Thanks,
Stefan

I'm waiting for Ext 4 support for this plugin!??