[FIXED][3.0rc2] IE setHeight

http://extjs.com/forum/showthread.ph...095#post343095

Ive removed the setHeight fix i was using and put in the syncHeight override provided.
The problem came back.

Another fix has been committed to resolve this problem.

Quote:

---

Originally Posted by evant

More info please, what are you doing that causes this to occur?

---

Ok, so same thing happens to me too with ExtJS 3.4.0.

The error thrown is at this line:

Code:

---

            !animate || !me.anim ?
                me.dom.style.height = me.addUnits(height) :
                me.anim({height : {to : height}}, me.preanim(arguments, 1));

---

height is an NaN.
me.addUnits(height) returns "NaNpx"
and IE does not agree to place a String at me.dom.style.height, while Chrome is ok with it.
This explains the illegal argument exception.

This above excerpt of code is from setHeight which is called from syncHeight:

Code:

---

    syncHeight : function(){
        var h = this.toolbarHeight,
                bd = this.body,
                lsh = this.lastSize.height,
                sz;


        if(this.autoHeight || !Ext.isDefined(lsh) || lsh == 'auto'){
            return;
        }




        if(h != this.getToolbarHeight()){
            h = Math.max(0, lsh - this.getFrameHeight());
            bd.setHeight(h);
            sz = bd.getSize();
            this.toolbarHeight = this.getToolbarHeight();
            this.onBodyResize(sz.width, sz.height);
        }
    },

---

Here lsh is "100%" and of course when performing the calculation:
h = Math.max(0, lsh - this.getFrameHeight());
the result of "100%" - 38 is NaN
after that bd.setHeight(h) is called with NaN.

So this bug is till open, and I fail to understand yet how to fix it.

Thanks,

Asaf

I also found a similar issue w/IE8 and Ext 3.1.1, I'm not sure if this the right place to post it [I hope Sencha support can correct me].

My structure

I had an Ext.form.ComboBox subclass in a panel, in a structure like this:

MyContainer1 > MyContainer2 > MyPanel > MyCombo

Using Ext.js 3

Trying to call setHeight([a positive value]) on MyContainer2 or doLayout() on MyContainer1 wouldn't work correctly on IE.

Analysis

At some point the comboBox doResize(w) method was being called with w undefined.

This was leading to the same effects described by @asafm , with setWidth(NaN) being called since Math.max( undefined, this.minListWidth) returns NaN;

My Fix

Code:

---

MyCombo = Ext.extend(Jx.form.JxComboBox, {
    //...
  doResize: function(w){       
        if(!Ext.isDefined(this.listWidth) && !isNaN(w)){
            var lw = Math.max(w, this.minListWidth);
            this.list.setWidth(lw);
            this.innerList.setWidth(lw - this.list.getFrameWidth('lr'));
        }
    }
}

---