emptyText is submitted with the form

Maybe rename emptyText to defaultValue since thats what it seems its intended use is and would be less confusing. Then also add helpText parameter which would never be submitted?

Quote:

---

Originally Posted by djliquidice

Jack,

Empty text is assumed to be used as a helper for customers. I realize what you're saying, but I also assumed it as well. I've since stopped using empty text where fields are not required to be filled in.


Eh, i can see both sides of the fence being right. Perhaps an option to not send the empty text value?

---

Especially as the emptyText is displayed differently (greyed) and disappears when you click on the field unlike regular text.

I had the same problem as other users in this thread, and find it a little unlogical that the getValue() function of a field returns '' if the field is empty and emptyText is set, but when you submit the form with form.submit() the emptyText values are submitted.

I'm using the following solution, which I think is a little cleaner, as you don't have to put it directly in the Ext source, but can include from somewhere else. Another thing is that if errors are returned from server side, the emptyText values will be put back on the fields.

HTML Code:

---

Ext.form.Action.Submit.prototype.run = Ext.form.Action.Submit.prototype.run.createInterceptor(function() {
  this.form.items.each(function(item) {
    if (item.el.getValue() == item.emptyText) {
      item.el.dom.value = '';
    }
    });
 });
Ext.form.Action.Submit.prototype.run = Ext.form.Action.Submit.prototype.run.createSequence(function() {
  this.form.items.each(function(item) {
    if (item.el.getValue() == '' && item.emptyText) {
      item.el.dom.value = item.emptyText;
    }
    });
 });

---

THX, That's good:D

solution

My solution:

Code:

---

Ext.onReady(function() {
    Ext.select("form").on('submit', function() {
        Ext.each(Ext.ComponentMgr.all.items, function() {
            if (typeof this.getValue == "undefined" || typeof this.el == "undefined") return;

            if (this.getRawValue() != this.el.getValue())
                this.setRawValue("");
        });
    });
});

---

Broady, this solution did not work for me.
and sebsei where to add lines if i don't have any html file, i have a .jsp

I am using Extjs 3.4 and there is an error "f.el is undefined" which is thrown if the element is a radio button. Any fix for this one?

Quote:

---

Originally Posted by trbs

okey i wrote a small workaround for this.
i'll have to say that i think this patch is less then ideal and i do not recommend patching ext in this way... but if you really want this problem solved try this:

add the following lines of code to Action.js line 108:

PHP Code:

---

  if (o.clientValidation === false || this.form.isValid()){
    this.form.items.each(function(f) {
        if (f.el.getValue() == f.emptyText) {
            f.el.dom.value = '';
        }
    });
    Ext.lib.Ajax.formRequest( 


---

The first and last line of the code block are the existing lines. You'll need to add the this.form.items.each block between them.

Explanation
The form.submit() action uses a form serializer instead of the getValue() field functions the raw dom value is send to the server. (this is the value including emptyText if the field is empty)

So the fix posted above does work, only not for a form.submit() action. Since i do not want to start editing in files other then those of ext themselfs. I build the above work around.

Just before the XHR submit-request to the server, this deletes the emptyText value from the dom. Then when the Ext.lib.Ajax.formRequest serializes the form there is no emptyText in there anymore.

The next time the form validates itself, the emptyText will reappear.

Related problems
You will also hit this problem if you use: form.getValues() as that method also uses the serializer.
This patch will not work for that, but i could use a similar workaround. (again remember, this is not very good
way to work around this... hopefully the ext team will come up with something better, like using getValue() methods or serializers that check for emptyText)

Attachment
The patched file attached here is based on the Ext 1.0.1 release.
Please apply the workaround yourself or do a diff; if you want to apply it on any other version.

Post Scriptum
If your client types the same value as emptyText in your Field the workaround will not do the desired thing. It will consider the typed value the same as emptyText, which it is clearly not. For 9 out of 10 people this will not be a problem, but if it is you should also check the css (aka the light grey text, instead of black typed text)

---

see this
http://www.sencha.com/forum/showthre...rking&p=552959