[INFOREQ] 3.2.2 Ext.Element Unmask problem

[Natalia R]

I’ve found a problem during migration from 3.1.1 to 3.2.2

I am using .mask() and .unmask() methods for toolbar element in my application.
After upgrade to 3.2.2 I found a bug:
1) I’ve call element.mask()
2) Then I call element.unmask()
3) ‘XMASKED’ class is still applied to element.

As I see .unmask() method of class Ext.Element is changed.

EXTJS 3.1.1.

        unmask : function(){
            var me = this,
                dom = me.dom,
                mask = data(dom, 'mask'),
                maskMsg = data(dom, 'maskMsg');
            if(mask){
                if(maskMsg){
                    maskMsg.remove();
                    data(dom, 'maskMsg', undefined);
                }
                mask.remove();
                data(dom, 'mask', undefined);
            }
            me.removeClass([XMASKED, XMASKEDRELATIVE]);

        }

EXTJS 3.2.2

      unmask : function(){
            var me = this,
                dom = me.dom,
                mask = data(dom, 'mask'),
                maskMsg = data(dom, 'maskMsg');
            if(mask){
                if(maskMsg){
                    maskMsg.remove();
                    data(dom, 'maskMsg', undefined);
                }
                mask.remove();
                data(dom, 'mask', undefined);
            }
            if(me.isMasked())
             { 
                me.removeClass([XMASKED, XMASKEDRELATIVE]);
            }
        },

           

          isMasked : function(){
                          var m = data(this.dom, 'mask');
                          return m && m.isVisible();
                      }

I think that XMASKED class is never be removed because the rule me.isMasked() is always returns FALSE.
On mask become ‘undefied’ according to :
data(dom, 'mask', undefined);
After that .isMasked() function is tries to get ‘mask’ property.

[Jamie Avins]

I show this as being fixed in the 3.3.x branch (currently in beta). Can you verify it was fixed in that revision?