[FIXED-1185] Adding phantom/dirty records to a store doesn't make them modified

[Condor]

From this post:
Adding a phantom or dirty record to a store doesn't automatically add it to the internal modified array, which also means they won't get saved when calling save().

I suggest changing:

Ext.override(Ext.data.Store, {
    add : function(records){
        records = [].concat(records);
        if(records.length < 1){
            return;
        }
        var modified = [];
        for(var i = 0, len = records.length; i < len; i++){
            records[i].join(this);
            if (records[i].dirty || records[i].phantom) {
                modified.push(records[i]);
            }
        }
        var index = this.data.length;
        this.data.addAll(records);
        if(this.snapshot){
            this.snapshot.addAll(records);
        }
        this.modified.push.apply(this.modified, modified);
        this.fireEvent('add', this, records, index);
    },
    insert : function(index, records){
        records = [].concat(records);
        var modified = [];
        for(var i = 0, len = records.length; i < len; i++){
            this.data.insert(index, records[i]);
            records[i].join(this);
            if (records[i].dirty || records[i].phantom) {
                modified.push(records[i]);
            }
        }
        if(this.snapshot){
            this.snapshot.addAll(records);
        }
        this.modified.push.apply(this.modified, modified);
        this.fireEvent('add', this, records, index);
    }
});

[edspencer]

Nice, though I went for this (and a similar change for insert):

add : function(records) {
    var i, record, index;
    
    records = [].concat(records);
    if (records.length < 1) {
        return;
    }
    
    for (i = 0, len = records.length; i < len; i++) {
        record = records[i];
        
        record.join(this);
        
        if (record.dirty || record.phantom) {
            this.modified.push(record);
        }
    }
    
    index = this.data.length;
    this.data.addAll(records);
    
    if (this.snapshot) {
        this.snapshot.addAll(records);
    }
    
    this.fireEvent('add', this, records, index);
},

The main difference is that I'm just pushing to this.modified inside the loop - was there a reason you chose not to?

[edspencer]

The change is now in svn and will appear in 3.3 beta 2