Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Ext JS Premium Member
    Join Date
    Apr 2007
    Posts
    4
    Vote Rating
    0
    dhawkins is on a distinguished road

      0  

    Default [CLOSED]Component.onShow and Component.onHide overwrite the animation.after function

    [CLOSED]Component.onShow and Component.onHide overwrite the animation.after function


    It would be nice if those methods wouldn't overwrite the .after function passed in the animation config.

    For example, the following example will never call the after function.

    Code:
    myComponent.hide({type: 'pop', after: function() { ... }});
    Inside Component.js the code for adding the after handler in onHide should be something like:
    Code:
    var after = function() {
        this.getVisibilityEl().hide();
    };
    if (hideConfig.after) 
        hideConfig.after = after.createInterceptor(hideConfig.after, hideConfig.scope||this);
    else 
        hideConfig.after = after;
    This will call the after function before calling the existing animation.after function
    The same should be done in the onShow function.

    --David

  2. #2
    Sencha - Ext JS Dev Team evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    16,953
    Vote Rating
    636
    evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute

      0  

    Default


    This is actually already the case, you should see it in the next release.
    Evan Trimboli
    Sencha Developer
    Twitter - @evantrimboli
    Don't be afraid of the source code!

Similar Threads

  1. Replies: 2
    Last Post: 1 Jul 2010, 7:26 AM
  2. Shift animation on component
    By mitchellsimoens in forum Ext 3.x: Help & Discussion
    Replies: 3
    Last Post: 12 Sep 2009, 6:28 AM
  3. How can I add a new function to an existing component?
    By anakonda8472 in forum Ext 2.x: Help & Discussion
    Replies: 2
    Last Post: 1 Mar 2008, 2:05 AM

Thread Participants: 1