Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Ext GWT Premium Member
    Join Date
    May 2010
    Posts
    53
    Vote Rating
    0
    crehbein is on a distinguished road

      0  

    Default [FNR] String comparison bug in BaseStringFilterConfig

    [FNR] String comparison bug in BaseStringFilterConfig


    Hi,

    I just noticed there's a bug in the isFiltered() method in BaseStringFilterConfig. isFiltered() is always returning true in a particular case where I'm setting up a filter to include all models with a value of "C" for some key, for example. The line that checks test vs. value is:

    Code:
    return v.toLowerCase().indexOf(t) == -1;
    if "C" is first converted to lower case, then indexOf("C") will always return -1, so it'd be filtered out.

    This bug is evident in the Remote Filter Grid example on your site by adding a filter for 'A'. I'd expect to see Apple and all the other companies whose names start with a capital 'A', but I get no results. Searching for 'a', on the other hand, works as expected.

    Thanks,
    - C

    PS - I take it back, searching for 'a' in the remote filter grid example doesn't work either, as it includes "Apple, Inc." in the results which doesn't contain a lower-case 'a'. What's the reason for the case conversion?

  2. #2
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    PS - I take it back, searching for 'a' in the remote filter grid example doesn't work either, as it includes "Apple, Inc." in the results which doesn't contain a lower-case 'a'. What's the reason for the case conversion?
    The clientside filtering is doing that too. I will change the serverside filtering to be exactly the same.

  3. #3
    Ext GWT Premium Member
    Join Date
    May 2010
    Posts
    53
    Vote Rating
    0
    crehbein is on a distinguished road

      0  

    Default


    Hi Sven, thanks for looking into this.

    What's the change going to be? I sort of assumed the BaseStringFilterConfig is the same for remote/local grids and both would have the same problems.

  4. #4
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    This should be fixed in SVN as of revision 2228 now. Can you validate this?

  5. #5
    Ext GWT Premium Member
    Join Date
    May 2010
    Posts
    53
    Vote Rating
    0
    crehbein is on a distinguished road

      0  

    Default


    I just synched up and looked at the code (haven't tried running against the new version yet). It looks like it should fix the problem. One quick question, though - is the intention to provide case-insensitive matching? I'm still not sure what the motivation is to convert the test and value strings to lower-case.

  6. #6
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    Yes, this is how it was implemented now. We cannot change this anymore now as this would be a braking change. we could have changed this in the prerelease phase.

  7. #7
    Ext GWT Premium Member
    Join Date
    May 2010
    Posts
    53
    Vote Rating
    0
    crehbein is on a distinguished road

      0  

    Default


    That's cool, as long as I know what to tell our users to expect. A nice feature would let us configure case-sensitivity when creating a StringFilter but I don't see it being that critical.

    Thanks for the help!
    - Chris

  8. #8
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    You could also use an own StringFitler/BaseStringFilterConfig class and override the methods with your own logic, if needed.

Similar Threads

  1. [FNR] LiveGridView setStripeRows Bug
    By support_csd_kz in forum Ext GWT: Bugs (2.x)
    Replies: 4
    Last Post: 17 Apr 2010, 8:30 AM
  2. [FNR] TimeField bug?
    By is84092 in forum Ext GWT: Bugs (2.x)
    Replies: 1
    Last Post: 12 Apr 2010, 5:02 AM
  3. [FNR] HtmlEditor tooltip bug
    By baskor in forum Ext GWT: Bugs (2.x)
    Replies: 1
    Last Post: 17 Mar 2010, 1:52 AM
  4. [FNR] Another Grid Reordering Bug
    By vez in forum Ext GWT: Bugs (2.x)
    Replies: 1
    Last Post: 15 Mar 2010, 3:08 AM
  5. [FNR-9][2.1.1] BorderLayout bug
    By micgala in forum Ext GWT: Bugs (2.x)
    Replies: 4
    Last Post: 3 Mar 2010, 6:06 AM

Thread Participants: 1