[INVALID-373] Animation callback scope set to config object instead of config.scope

[yui-ext is cool]

Sencha Touch version tested:

• 0.96

Platform tested against:

• iOS 3.x
• iOS 4
• Android 2.1
• Android 2.2

Description:

• In the onTransitionEnd callback function (ext-touch-debug.js line 10276 v .96), the scope for the "after" config callback function is being set to the actual config object instead of the config.scope (line 10303). I can't imagine why the callback scope would be set to the actual config object? if you pass a config with an 'after' callback and scope to the config of run() method, the scope is correctly set:

var opts2 = { 
scope: { 'test': 'test'}, 
after: function() { console.log(this); } 
};
new Ext.Anim(opts).run(el, opts2);

Description:

...
   if (me.config.after) {
            me.config.after.call(config, el, config);
        }

        if (o.after) {
            o.after.call(config.scope || me, el, config);
        }
...

Code to reproduce:

var el = Ext.getBody().createChild({
            style: 'background-color: red; width: 20px; height: 20px; top:150px; position:absolute; opacity: 0.0001;'
        });
var opts = {
scope: { 'test': 'test' },
autoClear: false,
before: function(el){  this.to = { 'opacity': '1' }; },
after: function() { console.log('Anim callback'); console.log(this); }
};

var opts2 = { 
scope: { 'test': 'scope from run config' },
after: function() { console.log('run callback'); console.log(this); } 
};
new Ext.Anim(opts).run(el, opts2);

Possible fix:

...
   if (me.config.after) {
            me.config.after.call(config.scope || me, el, config);
        }

        if (o.after) {
            o.after.call(config.scope || me, el, config);
        }
...

Additional Question:
Why are there 2 places you can set the callback for an animation?
Is there a preferred place to put the callback?

[BrendanC]

Thanks for the bug report. The team is reviewing your suggestion and they will let you know what they decide.

[evant]

Though I didn't write this code, I think I can see the intent. Also note that the same applies for before as well.

The before/after for the anim are about setting up any initial values on the animation itself, for example if you look at one of the preset animations, you see it's setting the from/to for the animation to actually do anything. The before/after on the config are intended for any ~other~ things, for example if you wanted to chain events or do something once the animation has finished.

I think it's more a documentation issue that needs to be cleared up, because the intent is definitely to set the scope to the animation for both of the before/after on the anim.

[edspencer]

I'm not sure why this is written this way, but are you seeing an actual bug? Adding scope works correctly for your before/after callback functions.

[edspencer]

Closed this as no actual bug appears to be present.