[CLOSED][3.3.0-rc]Ext.grid.ColumnModel -> destroy

[tobiu]

hi team,

this method seems to have changed in 3.3:

    destroy : function() {
        var length = this.config.length,
            i = 0;

        for (; i < length; i++){
            this.config[i].destroy(); // Column's destroy encapsulates all cleanup.
        }
        delete this.config;
        delete this.lookup;
        this.purgeListeners();
    }

i sometimes get the error in firebug:

this.config[i].destroy is not a function
[Break on this error] this.config[i].destroy();

i guess it happens when a column or the cm itself is not yet rendered when calling destroy().
adding a check for this should help.


kind regards
tobiu

[tobiu]

update: the theory was wrong. the error occured when using sakis rowactions-plugin with 3.3 (the column does not have a destroy-method).

so, this is not really an ext bug. i added a check if destroy exists, just in case.

Ext.override(Ext.grid.ColumnModel, {
    destroy : function() {
        var length = this.config.length,
            i = 0;

        for (; i < length; i++){
            if(typeof this.config[i].destroy == 'function'){
                this.config[i].destroy(); // Column's destroy encapsulates all cleanup.
            }
        }
        delete this.config;
        delete this.lookup;
        this.purgeListeners();
    }
});

[Animal]

RowActions have been replaced by ActionColumn in 3.3

http://dev.sencha.com/deploy/ext-3.3...d.ActionColumn

http://dev.sencha.com/deploy/ext-3.3...rray-grid.html