[OPEN-1387] Radiogroup reset clears all values

**kvr** · 3 Nov 2010 6:29 AM

Ext version tested:

Ext 3.2.1

Adapter used:

ext

css used:

only default ext-all.css

Browser versions tested against:

IE8
IE9
FF3 (firebug 1.3.0.10 installed)

Operating System:

Linux Ubuntu 10.10 64
WinXP Pro

Description:

Resetting a radiogroup causes all radios to be disabled, rather than
reverting back to the original value. As reset is used by form reset this
is rather troublesome.

Test Case:

Code:

<html>
    <head>
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
        <title id='title'>Radiogroup reset</title>

        <link rel="stylesheet" type="text/css" href="../../resources/css/ext-all.css" />

        <script type="text/javascript" src="../../adapter/ext/ext-base.js"></script>
        <script type="text/javascript" src="../../ext-all-debug.js"></script>

        The radiogroup below has default value choice2.<br>
        When we reset the radiogroup, all fields are cleared rather than being reset to the originalValue.<br>
        This is especially troublesome as reset is used by BasicForm.reset.<br><br>
        <div id="content"></div>

        <script type="text/javascript">
        Ext.onReady(function(){

            new Ext.FormPanel({
                renderTo: 'content',
                items: [{
                    "id":"rg", "name":"rg", "xtype":"radiogroup", "value":"Choice 2", "items":[
                        {"inputValue":"Choice 1","boxLabel":"choice1","name":"rg"},
                        {"inputValue":"Choice 2","boxLabel":"choice2","name":"rg"}
                    ]}, {
                        xtype: 'button',
                        text: 'reset',
                        handler: function () { Ext.getCmp("rg").reset() },
                        scope: this
                    }]
            });

        }); //end onReady
        </script>
    </head>
    <body>
    </body>
</html>

Steps to reproduce the problem:

Create a radiogroup
set a default value
Call reset

The result that was expected:

The radiogroup should select the default value on reset

The result that occurs instead:

All selections are cleared making for a very sily radiogroup

Debugging already done:

It seems the checkboxgroup reset function supports two methods to set the default value:
If orginalValue is set, use it
but, originalValue is never set (normally this happens in the initValue function, but checkbocgroup has overriden this function and it does not call super and does not set the originalValue.
when no originalValue is set, the reset function will ask the individual radiobuttons to reset themselves to their defaultvalue
but radiogroup/checkboxgroup set the indivial radio values after the originalValue was stored, so the radios are always empty.

Possible fix:

Code:

// on radiogroup.reset all checkboxes are cleared
Ext.form.RadioGroup.override({
        initValue : function(){
                if(this.value){
                        this.originalValue=this.value[0];
                        this.setValue.apply(this, this.buffered ? this.value : [this.value]);
                        delete this.buffered;
                        delete this.value;
                }
        }
});

[OPEN-1387] Radiogroup reset clears all values

Thread Tools

Search Thread

Display

Threaded View

[OPEN-1387] Radiogroup reset clears all values

[OPEN-1387] Radiogroup reset clears all values

Similar Threads

BasicForm.reset: Resets to default values?

[2.2][CLOSED] BasicForm.updateRecord updates clears values

Reset button to clear form values?

Tags for this Thread