[OPEN-1410] Ext.form.ComboBox and the expand() method

[Jaitsu]

I was just wondering why in the expand method on an Ext.form.ComboBox there is a check to ensure the combo has focus before actually expanding...

expand : function(){
        if(this.isExpanded() || !this.hasFocus){
            return;
        }
        //....

I can't see any reason why the combo would have to have focus before expanding, and it works without having focus if you remove the check. I think expanding the combo is a nice way of letting the user know that data has been loaded into the store without actually setting a value. Its obviously straightforward to focus the field, but I don't want to steal the focus I just want to inform the user that data has been loaded.

Anyone have any thoughts on this?

[Condor]

expand() should never be called directly. Call onTriggerClick() instead.

[Jaitsu]

This makes sense looking at the code, but why is expand() a public method in the API?

[Condor]

Good question. Maybe we should move this to the Bugs section to let the developers decide?

[Jaitsu]

Yeah if you could move it that would be great. Its just a little confusing looking at the API docs, I've previously always used expand() and that's obviously wrong.