[TOUCH-428] Store.snapshot contains corrupt data.

[SimonFlack]

Sencha Touch version tested:

• 1.0.1a

• only default ext-all.css

Description:

• Store snapshot is corrupt after changing a proxies data source and reloading the store.
• Similar problems also happen if using paging. Clearing the filter causes the first page to be reloaded into the store from the snapshot.

clearFilter : function(suppressEvent) {
        this.filters.clear();
        
        if (this.isFiltered()) {
            this.data = this.snapshot.clone();
            delete this.snapshot;

            if (suppressEvent !== true) {
                this.fireEvent('datachanged', this);
            }
        }
    },

Test Case:

    
Ext.regModel('SomeModel', {fields: ['name']});

var myProxy = new Ext.data.MemoryProxy({
	type: 'memory',
	reader: {
		type: 'json',
		root: 'root'
	}
});

var data1 = {
	root: [
		{name: 'One'},
		{name: 'Two'},
	]
};

var data2 = {
	root: [
		{name: 'Cat'},
		{name: 'Dog'},
		{name: 'Fish'}
	]
};

var myStore = new Ext.data.Store({
	model: 'SomeModel',
	proxy: myProxy
	 
});
	
	//Setup 
Ext.setup({
    icon: 'icon.png',
    glossOnIcon: false,
    onReady: function() {
	
		var myList = new Ext.List({
			id: 'theList',
			fullscreen: true,
			itemTpl : '{name}',
			store: myStore
		});
			
	}
});

Steps to reproduce the problem: (In Console)

• Ext.getCmp('theList').store.proxy.data = data1
  
• Ext.getCmp('theList').store.load()
  
• Ext.getCmp('theList').store.proxy.data = data2
  
• Ext.getCmp('theList').store.load()
  
• Ext.getCmp('theList').store.filter('name', 'Fish')
  
• Ext.getCmp('theList').store.clearFilter()

The result that was expected:

• One, Two ( After first load() )
• Cat, Dog, Fish ( After second load() )
• Fish ( After filtering)
• Cat, Dog, Fish ( After clearFilter())

The result that occurs instead:

• One, Two ( After first load() )
• Cat, Dog, Fish ( After second load() )
• Fish ( After filtering)
• One, Two ( After clearFilter() )

Screenshot or Video:


Possible fix:

• Update the Store's snapshot when proxies data is changed. For example if the application changes the "url" of a RESTProxy and then reloads the store the snapshot shoult contain this new data and not the data from the original loaded data.

[oyvinht]

I can verify that adding:

someStore.on('load', function (store) {
store.snapshot = store.data;
});

makes filtering/clearing work as desired.

--
Oyvin

[d5chris]

Me too having a problem with this bug:

http://www.sencha.com/forum/showthre...460#post581460

Please fix.

Our team also has a paid support account under the name 'pdiemert' FWIW.

[ostkaka]

The bug is still present in 1.1

For some reason oyvinht's fix didn't work for me so I added the following code to the loadRecords function.

   this.data = this.snapshot.clone();
   delete this.snapshot;
   this.fireEvent('datachanged', this);

[jep]

Very frustrating problem. Seems like a flaw in some of the rather basic core functionality of a store.

[dolittle]

This is a serious bug that is known for several months:
http://www.sencha.com/forum/showthre...hen-using-load
http://www.sencha.com/forum/showthre...Store.loadData
http://www.sencha.com/blog/ext-js-4-...released#19311

[anselmtmcclain]

We added this override (the line below the big starred comment) to delete the snapshot. Not thoroughly tested by any means but seems to solve the issues we were having. Any feedback?

Bizarre that this has not been fixed. Thanks - ATM

Ext.override(Ext.data.Store, {
    loadRecords: function(records, add) {
           if (!add) {
               this.data.clear();
           }

           this.data.addAll(records);
           // ***************************************************************
           // As of Touch 1.1 the snapshot is not updated/cleared properly on data load.
           // ***************************************************************
           if (this.snapshot) delete this.snapshot;

           for (var i = 0, length = records.length; i < length; i++) {
               records[i].needsAdd = false;
               records[i].join(this);
           }

           this.suspendEvents();

           if (this.filterOnLoad && !this.remoteFilter) {
               this.filter();
           }

           if (this.sortOnLoad && !this.remoteSort) {
               this.sort();
           }

           this.resumeEvents();
           this.fireEvent('datachanged', this, records);
       }
});

[sandeep45]

I am reloading the store by changing its proxies url and then calling load. Now although store.data has the correct data, store.snapshot.data has the wrong data.

[mike.estes]

I've modified this thread to reflect the correct bug id

[fox1charlie]

I have the same problem.
The override specified above fixes it though.