[3.3.0] Ext.grid.GridPanel -> enableDragDrop : true & CheckboxSelectionModel

[tobiu]

hi team,

i just tried to combine a GridPanel with CheckboxSelectionModel and enableDragDrop and noticed, that nothing happens when you click on a checkbox as soon as enableDragDrop is set to true.

to reproduce this, it is important to use the config:

    var sm = new Ext.grid.CheckboxSelectionModel({
        checkOnly : true
    });

with checkOnly : false, it works fine.

for a testcase use examples/grid/grid-plugins.html

and change grid-plugins.js:

    ////////////////////////////////////////////////////////////////////////////////////////
    // Grid 2
    ////////////////////////////////////////////////////////////////////////////////////////
    var sm = new xg.CheckboxSelectionModel({
        checkOnly : true
    });

    var grid2 = new xg.GridPanel({
        enableDragDrop : true,
        store: new Ext.data.Store({
            reader: reader,
            data: xg.dummyData
        }),
        cm: new xg.ColumnModel({
            defaults: {
                width: 120,
                sortable: true
            },
            columns: [
                sm,
                {id:'company',header: "Company", width: 200, dataIndex: 'company'},
                {header: "Price", renderer: Ext.util.Format.usMoney, dataIndex: 'price'},
                {header: "Change", dataIndex: 'change'},
                {header: "% Change", dataIndex: 'pctChange'},
                {header: "Last Updated", width: 135, renderer: Ext.util.Format.dateRenderer('m/d/Y'), dataIndex: 'lastChange'}
            ]
        }),
        sm: sm,
        columnLines: true,
        width:600,
        height:300,
        frame:true,
        title:'Framed with Checkbox Selection and Horizontal Scrolling',
        iconCls:'icon-grid',
        renderTo: document.body
    });

best regards
tobiu

[Andrew Peacock]

Hi Tobias,

Many thanks for sharing your solution - you've just saved me a lot of time searching!

Regards,
Andy

[tobiu]

it would be nice if this issue could find its way into the bugtracker after 3 months


best regards
tobiu

[tobiu]

hi team,

i needed a fast solution, so:

Ext.override(Ext.grid.GridDragZone, {
    getDragData : function(e){
        var t = Ext.lib.Event.getTarget(e);
        var rowIndex = this.view.findRowIndex(t);
        if(rowIndex !== false) {
            var sm = this.grid.selModel;

            if (sm instanceof(Ext.grid.CheckboxSelectionModel)) {
                sm.onMouseDown(e, e.getTarget());
            }

            else if(!sm.isSelected(rowIndex) || e.hasModifier()) {
                sm.handleMouseDown(this.grid, rowIndex, e);
            }
            return {grid: this.grid, ddel: this.ddel, rowIndex: rowIndex, selections:sm.getSelections()};
        }
        return false;
    }
});

it would be nice, if this gets into svn.


best regards
tobiu

[j-joey]

with this fix, it should behave completely natural

Ext.override( Ext.grid.GridDragZone, {
    getDragData : function( e ) {
        var t = Ext.lib.Event.getTarget(e);
        var rowIndex = this.view.findRowIndex(t);
        if ( rowIndex !== false ) {
            var sm = this.grid.selModel;

            if ( sm instanceof( Ext.grid.CheckboxSelectionModel ) ) {
                sm.onMouseDown( e, t );
            }
            
            if( t.className != 'x-grid3-row-checker' && ( !sm.isSelected( rowIndex ) || e.hasModifier() ) ) {
                sm.handleMouseDown( this.grid, rowIndex, e );
            }
            return { grid: this.grid, ddel: this.ddel, rowIndex: rowIndex, selections:sm.getSelections() };
        }
        return false;
    }
} ); 

[Golu]

Thanks tobiu. Thanks a lot. you have save my lot of time.


Once again Thanks

[rich02818]

What is the bug number for this problem? It was reported 29 months ago.