[FIXED] Ext.DataView.beforeselect not firing

[n3rd]

The documentation specifies the 'beforeselect' event, but it appears that this event is never triggered.

A quick look at Ext.DataView's source seems to confirm this: the event is indeed never fired.

Edit: Apparently, this has been mentioned before but no feedback was given.

[n3rd]

Unfortunately, the bug was not resolved in PR4:

    onSelectChange: function(record, isSelected, suppressEvent) {
        var me = this,
            view = me.view,
            allowSelect = true,
            select;
        
        if (isSelected) {
            if (!suppressEvent) {
                select = me.fireEvent('beforeselect', me, record) !== false;
            }
            if (allowSelect) {
                view.onItemSelect(record);
                if (!suppressEvent) {
                    me.fireEvent('select', me, record);
                }
            }
        } else {
            view.onItemDeselect(record);
            if (!suppressEvent) {
                me.fireEvent('deselect', me, record);
            }
        }
    }

The "beforeselect" event is indeed now fired, but its return value is completely ignored. I don't want to be a , but it seems to me like that feature was implemented but never actually tested or even used...

[evant]

Looks like I accidentally committed without saving:

Ext.selection.DataViewModel.override({
    onSelectChange: function(record, isSelected, suppressEvent) {
        var me = this,
            view = me.view,
            allowSelect = true;
        
        if (isSelected) {
            if (!suppressEvent) {
                allowSelect = me.fireEvent('beforeselect', me, record) !== false;
            }
            if (allowSelect) {
                view.onItemSelect(record);
                if (!suppressEvent) {
                    me.fireEvent('select', me, record);
                }
            }
        } else {
            view.onItemDeselect(record);
            if (!suppressEvent) {
                me.fireEvent('deselect', me, record);
            }
        }
    }
});

[n3rd]

Thanks a lot for the quick reply. It's very much appreciated!