[FNR] Problems with RowLayout

[The_Jackal]

One of the support guys agreed that it's a problem, but did not give any time frames. Looking at how many issues are not being answered on this forum at the moment, my guess is that GXT3 is the current focus. Seeing that even raising a ticket didn't prompt a patch, I'd say you'd be better to work around this issue for now.

[The_Jackal]

Note that this issue is still not fixed in the 2.2.4 release

[sven]

This thread will be updated once its fixed.

[sven]

I removed the change for now as long as isVisible is implemented correctly.

[The_Jackal]

Thanks Sven,

So this fixes the layout issues (rev 2394) - is the visibility issue you were worried about still a problem?

Regards,
Carl.

[sven]

Yes, and the thread that coursed this change was much longer and more often on internal tickets. However as the second half of the patch did not make it into GXT so far, i reverted the change.

[jCOM1]

Even in the most up to date SVN version the RowLayout doesn't work if you use Orientation.HORIZONTAL as you can see in this simple use case:

    public void onModuleLoad() {
        LayoutContainer lc = new LayoutContainer(new RowLayout(
                Orientation.HORIZONTAL));
        lc.add(new Text("Item1"));
        lc.add(new Text("Item2"));
        RootPanel.get().add(lc);
        lc.layout(true);
    }

Executing this code results in a white browser screen, no text is displayed.
Using FireBug you can see that all html tags are present, but somehow not displayed.

Changing from Orientation.VERTICAL to Orientation.HORIZONTAL you can see that the LayoutContainers style-attribute gets extended by postition: relative; which seems to be the cause for not showing the text elements.

RowLayoutIssue.jpg

Investigating the RowLayout class it seems to be the onLayout method which adds this style be calling target.makePositionable();

  @Override
  protected void onLayout(Container<?> container, El target) {
    super.onLayout(container, target);

    if (container instanceof ScrollContainer<?>) {
      ScrollContainer<?> sc = (ScrollContainer<?>) container;
      sc.setScrollMode(sc.getScrollMode());
    } else {
      target.setStyleAttribute("overflow", "hidden");
    }

    if (orientation == Orientation.VERTICAL) {
      layoutVertical(target);
    } else {
      target.makePositionable();
      layoutHorizontal(target);
    }
  }

Any suggestions how to solve this problem?

[sven]

You need to size your layoutcontainer, this is not a bug.