[FIXED-EXTJSIV-1818][4.0.0] record.destroy() callbacks not executed

[bas_tzx]

I am deleting a node from a tree and I want to use the callbacks to see whether the serverside action has been successful.

Sadly, the destroy method doesn't seem to work. As a workaround I can call the doRequest method on the proxy.

var store = this.getStructuresStore(), //Ext.data.TreeStore
      record = tree.getView().getSelectedRecords()[0];

// Callbacks not executed
record.destroy({
    failure: function () {
        console.log('destroy failure!');
    },
    success: function () {
        console.log('destroy success!');
    },
    callback: function () {
        console.log('destroy callback!');
    }
});

// This works
var operation = new Ext.data.Operation({
    action: 'destroy',
    id: record.getId()
});

store.getProxy().doRequest(operation, function () {
    console.log('request callback');
});

[evant]

Can't reproduce this:

Ext.define('Item', {
    extend: 'Ext.data.Model',
    fields: ['id', 'foo'],
    proxy: {
        type: 'ajax',
        url: 'data.json'
    }
});

Ext.onReady(function() {
    
    var rec = new Item({
        id: 1,
        foo: 'bar'
    }, 1);
    
    rec.destroy({
        success: function(){
            console.log('success');
        },
        callback: function(){
            console.log('callback');
        },
        failure: function(){
            console.log('failure');
        }
    });
    
});

Server returns:

{"success": true}

[bas_tzx]

To be more specific:

The Ext.data.Model.destroy() method works, it performs the ajax request, but the succes/failure callbacks are not executed.

If I use record.save() or the Ext.data.proxy.Rest.doRequest() everything works fine.

[evant]

As I said above, I can't reproduce it, the callbacks fire just fine for me.

[haorenpingan030]

//I define a Flow model as follows(Using some rest):

Ext.define('Flow', {
extend : 'Ext.data.Model',
fields : [ {
name : 'id',
type : 'int'
}, {
name : 'name',
type : 'string'
}, {
name : 'owner',
type : 'string'
}, {
name : 'ctime',
type : 'string'
} ],
proxy : {
type : 'rest',
url : '/flow',
reader : 'json'
}
});

//selModel is a instance of Flow. It can be destroyed, but the callbacks(success, failure, callback) are not be called.

selModel.destroy({
success : function() {
console.log('success?');
},
failure : function() {
console.log('fail?');
},
callback : function(record, operation) {
console.log('callback');
}
});

//Enjoy the question!

[bas_tzx]

The following code renders a treePanel with a treeStore and an ajax proxy. I've put 2 buttons in the toolbar which both select a node and then destroy the selected record. The first button calls the destroy method on the record and these callbacks do not work (the request is made twice, so that's also a bit strange). The second button uses the proxy doRequest method and this callback works.

Hopefully this code will give a better explaination (and will be probably show that I am doing something stupid )

var store = Ext.create('Ext.data.TreeStore', {
    root: {
        expanded: true,
        text: "root",
        children: [{
                id: 1,
                text: "Node 1.1",
                leaf: true
            },{
                id: 2,
                text: "Node 1.2",
                leaf: true
            },{
                id: 3,
                text: "Node 1.3",
                leaf: true
            },{
                id: 4,
                text: "Node 1.4",
                leaf: true
            },{
                id: 5,
                text: "Node 1.5",
                leaf: true
            }]
    },
    proxy: {
        type: 'ajax',
        url: 'delete.json' // Returns { "success" : true }
    }
});


Ext.onReady(function () {

    var tree = Ext.create('Ext.tree.Panel', {
        title: 'Model (record) destroy test',
        width: 300,
        height: 400,
        store: store,
        renderTo: Ext.getBody(),
        tbar: [{
            xtype: 'button',
            text: 'record.destroy',
            handler: function () {
                var record,
                      selModel = tree.getView().getSelectionModel();

                // Select 2nd record
                selModel.select(1);

                // Get record
                record = selModel.getSelection()[0];

                console.log('record', record);

                // Callbacks not executed
                record.destroy({
                    failure: function () {
                        console.log('destroy failure!');
                    },
                    success: function () {
                        console.log('destroy success!');
                    },
                    callback: function () {
                        console.log('destroy callback!');
                    }
                });
            }
        }, {
            xtype: 'button',
            text: 'proxy.doRequest',
            handler: function () {
                var record,
                      operation,
                      selModel = tree.getView().getSelectionModel();

                // Select 2nd record
                selModel.select(1);

                // Get record
                record = selModel.getSelection()[0];

                console.log('record', record);

                operation = new Ext.data.Operation({
                    action: 'destroy',
                    id: record.getId()
                });

                // This callback works
                tree.getStore().getProxy().doRequest(operation, function () {
                    console.log('doRequest callback');
                });

            }
        }]
    });

}); 

[evant]

Ok I see, it's something specifically affecting models decorated with NodeInterface. This should be resolved in the next release.

[bas_tzx]

OK, thanks!

[nicobarten]

I'm using 4.1.1a and i'm still having this problem.