[4.0.0] Bug in AbstractView.updateIndexes

[westy]

Hi,

Believe I've found an issue in updateIndexes.
It's seems to be getting called when calling removeAll on a tree node, during a load (when clearOnLoad is true).

Anyway, code:

    updateIndexes : function(startIndex, endIndex) {
        var ns = this.all.elements,
            records = this.store.getRange();
        startIndex = startIndex || 0;
        endIndex = endIndex || ((endIndex === 0) ? 0 : (ns.length - 1));
        for(var i = startIndex; i <= endIndex; i++){
            ns[i].viewIndex = i;
            ns[i].viewRecordId = records[i].internalId;
            if (!ns[i].boundView) {
                ns[i].boundView = this.id;
            }
        }
    }, 

The issue is that sometimes records[i] is outside of the bounds of the collection.
Not entirely sure why, or what this method is meant to be doing, but it could probably be a bit more defensive I think.

Cheers,
Westy

[stevil]

I've seen this once before, and I can't remember how I got around it - but if ns (this.all.elements) has length 0, and both startIndex and endIndex are 0, that would happen...

[westy]

I'm generally seeing it on the last child node... have kind of worked around it for now, but it's leaves the UI in a mess.

Basically overridden my tree view's updateIndexes, and put a try..catch around callParent; meaning I get nodes staying in the tree, but at least I can keep testing, which is sufficient for my current focus.

Cheers

[westy]

My override for the moment:

    updateIndexes : function(startIndex, endIndex) {
        var ns = this.all.elements,
            records = this.store.getRange();
        startIndex = startIndex || 0;
        endIndex = endIndex || ((endIndex === 0) ? 0 : (ns.length - 1));
        for(var i = startIndex; i <= endIndex; i++){
            ns[i].viewIndex = i;
            ns[i].viewRecordId = records.length >= i ? records[i].internalId : undefined;
            if (!ns[i].boundView) {
                ns[i].boundView = this.id;
            }
        }
    }, 

But I suspect there's some underlying problem causing this.store.getRange to not return a set that matches this.all.elements length.

Cheers,
Westy

[stevil]

There are definitely some things that are in need of null and range checking...

stevil

[astuteq]

Hello,
I have also an issue with AbstractView.updateIndexes / reloading a TreeStore.

I discovered a problem when reloading a TreeStore quick successive order.
Here is my store configuration:

Ext.define('Rekuma.store.Reseller.Tree', {
    extend: 'Ext.data.TreeStore',
    model: 'Rekuma.model.TreeNode',
    autoLoad: true,
    clearOnLoad: true,
    proxy:  {
                type: 'ajax',
                url : 'menu/reseller',
                actionMethods: {
                    read   : 'POST'
                },
                extraParams: {
                    category: 'reseller'
                }
            }
        }
    ); 

This is what I do in my controller:

Ext.define('Rekuma.controller.Navigation', {
    extend: 'Ext.app.Controller',
    views: [
        'navigation.PrimaryTreePanel'
    ],
    stores: [
        'Reseller.Tree'
    ],
    init: function() {

        this.control({
            'viewport > panel > primarytreepanel': {
                selectionchange: this.selectionChanged
            },
            'viewport > panel > primarytreepanel > toolbar > button': {
                click: this.refresh
            }
        });
    },
    selectionChanged: function (view, selections){
    },
    refresh: function() {
        this.getResellerTreeStore().load();
    }
}); 

Everything works fine as long as I press the refresh button slowly.
If I load the store in a quick, successive order, I get the message:

TypeError: Result of expression 'records[i]' [undefined] is not an object. AbstractView.js:492

Also, I see TreeNodes twice.
I get the same behavior on every click, if I set clearOnLoad: false

Stefan

[westy]

My override for the moment:

    updateIndexes : function(startIndex, endIndex) {
        var ns = this.all.elements,
            records = this.store.getRange();
        startIndex = startIndex || 0;
        endIndex = endIndex || ((endIndex === 0) ? 0 : (ns.length - 1));
        for(var i = startIndex; i <= endIndex; i++){
            ns[i].viewIndex = i;
            ns[i].viewRecordId = records.length >= i ? records[i].internalId : undefined;
            if (!ns[i].boundView) {
                ns[i].boundView = this.id;
            }
        }
    }, 

But I suspect there's some underlying problem causing this.store.getRange to not return a set that matches this.all.elements length.

Cheers,
Westy

Whoops, bug in this.

Fixed:

    updateIndexes : function(startIndex, endIndex) {
        var ns = this.all.elements,
            records = this.store.getRange();
        startIndex = startIndex || 0;
        endIndex = endIndex || ((endIndex === 0) ? 0 : (ns.length - 1));
        for(var i = startIndex; i <= endIndex; i++){
            ns[i].viewIndex = i;
            ns[i].viewRecordId = ((records.length > i) && records[i]) ? records[i].internalId : undefined;
            if (!ns[i].boundView) {
                ns[i].boundView = this.id;
            }
        }
    }, 

[karnak]

I am still getting this error in 4.0.2. Your fix seems to work great (as I am no longer getting errors in my console window). Are the Sencha team aware of this?